[FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

James Almer jamrial at gmail.com
Fri May 22 17:21:11 EEST 2020


On 4/10/2020 11:07 AM, Derek Buitenhuis wrote:
> On 10/04/2020 00:09, James Almer wrote:
>> EAGAIN is returned when input is provided but can't be consumed. The filtering
>> process is unaffected in this case, and the function will be able to consume
>> new input after retrieving filtered packets with av_bsf_receive_packet().
>>
>> Remove the line about empty packets never failing added in
>> 41b05b849f215b03eeb9e3608571ba47de64182a while at it. Even if it's currently
>> the case, it unnecessarily constrains the API and could be changed in the future
>> in case it needs to be extended.
>> The user should always check for errors and never expect a call to never fail.
>>
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>  libavcodec/avcodec.h | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> Sounds good to me.
> 
> - Derek

Pushed, thanks.


More information about the ffmpeg-devel mailing list