[FFmpeg-devel] [PATCH 1/3] apedec: add ability to check CRC

[Lynne]

May 22, 2020, 23:50 by ceffmpeg at gmail.com:

> Am Sa., 23. Mai 2020 um 00:43 Uhr schrieb Lynne <dev at lynne.ee>:
>
>>
>> Posting this again.
>>
>> The CRC flag is only signalled once every few minutes but CRC is still
>> always present so the patch uses the file version instead.
>>
>> CRC on 24-bit files wants non-padded samples so skip such files.
>>
>
> Should a warning be printed (once) for the 24-bit case if crc check
> was requested?
>

I'm not sure, but I think I'd be inclined to say not here. We don't print warnings
in other codecs when error checking is requested but unsupported by the codec.
Its an optional feature that itself warns the user that there was a corruption in the file,
and if the explode option is set, makes the warning an error and prevents further
decoding of the corrupt block.



> And please remove the parentheses from the first if, parentheses
> in the second if are also superfluous...
>

Done.