[FFmpeg-devel] [PATCH v4 1/2] fftools: add options to dump filter graph

Nicolas George george at nsup.org
Sat May 23 17:36:24 EEST 2020


Limin Wang (12020-05-23):
> OK, if nobody object it, I'll remove it after the patchset are OK.

That should be in the same patch.

> I have no idea how to use parse_key_value_pair() and how to support it in command
> line with option? so I use it as format directly.

The answer to something we do not know should be to learn, not to do
without and result in an inferior implementation.

I am very much opposed to turning this option into just the name of the
format, especially now that it starts getting extended.

In this case, transforming the string into an AVDictionary, passing it
around and warning if there are remaining options should be the simplest
choice.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200523/f5f326af/attachment.sig>


More information about the ffmpeg-devel mailing list