[FFmpeg-devel] [PATCH] Don't adjust start time for MP3 files; packets are not adjusted.

[Michael Niedermayer]

On Wed, May 27, 2020 at 11:57:13AM -0700, Dale Curtis wrote:
> On Wed, May 27, 2020 at 8:29 AM Michael Niedermayer <michael at niedermayer.cc>
> wrote:
> 
> > what id like to point out here is that the audio stream no
> > longer starts at the same time as the video
> > also the duration from adding the durations before is
> > exact but not afterwards
> >
> 
> I'm not sure about the duration issue, I'd assume it's just an accounting
> error since the change only affects start_time. As noted in the change
> description, if you want to keep start_time adjusted for skip samples all
> packet timestamps need to be changed too. Doing that broke many test cases
> at the time, so we opted to just revert the patch. I.e., basically every
> mp3 changes to having its first PTS be ~26ms due to the common 1152 skip
> sample amount.

I dont really have an oppinion about start_time, its more the change in
timestamps & duratiion on the output side which is whats user vissible
and that looked worse for the testcase

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200528/c6bb11b4/attachment.sig>