[FFmpeg-devel] [RFC PATCH] libavcodec/jpeg2000_parser: Add jpeg2000 parser

[Michael Niedermayer]

On Fri, May 29, 2020 at 11:23:20PM +0530, Gautam Ramakrishnan wrote:
> On Fri, May 29, 2020 at 5:01 AM Michael Niedermayer
> <michael at niedermayer.cc> wrote:
> >
> > On Fri, May 29, 2020 at 12:33:01AM +0530, gautamramk at gmail.com wrote:
> > > From: Gautam Ramakrishnan <gautamramk at gmail.com>
> > >
> > > I have attempted to write a JPEG2000 Parser. Have tested
> > > by generating a file containing 14 frames, as mentioned
> > > by Micheal. Have also tried testing with various packet
> > > sizes by setting -frame_size option. Need feedback on the
> > > code and on further testing.
> > > ---
> > >  libavcodec/Makefile          |   1 +
> > >  libavcodec/jpeg2000_parser.c | 190 +++++++++++++++++++++++++++++++++++
> > >  libavcodec/parsers.c         |   1 +
> > >  3 files changed, 192 insertions(+)
> > >  create mode 100644 libavcodec/jpeg2000_parser.c
> >
> > can you add some test to fate for this ?
> > (doesnt need to be related to the tests you did, but can of course)
> > such a test would also make it easy for others to test the code on
> > less common hardware like big endian ...
> > This can also be very simple test if its not easy
> Small doubt, so the jpeg2000 stream to be parsed goes in the
> test-suite directory and the corresponding framecrc goes into the
> test/ref directory? Is my understanding right?

ideally the teststream is generated by our muxers / encoders, that way 
it doesnt need to be added to the fate suite
and it also teste more code as a side effect

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Take away the freedom of one citizen and you will be jailed, take away
the freedom of all citizens and you will be congratulated by your peers
in Parliament.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20200529/0b2d50dc/attachment.sig>