[FFmpeg-devel] [PATCH v5 0/9] avformat: wav-s337m support + new probe_stream option

Nicolas George george at nsup.org
Mon Nov 9 11:40:15 EET 2020


Nicolas Gaullier (12020-11-09):
> > doc/formats.texi            |  3 ++
> > libavcodec/dolby_e.c        |  1 +
> > libavformat/avformat.h      |  9 ++++-
> > libavformat/options_table.h |  1 +
> > libavformat/s337m.c         | 73 ++++++++++++++++++++++++++++++++-----
> > libavformat/s337m.h         | 54 +++++++++++++++++++++++++++
> > libavformat/utils.c         |  2 +
> > libavformat/version.h       |  2 +-
> > libavformat/wavdec.c        | 53 ++++++++++++++++++---------
> > tests/Makefile              |  1 +
> > tests/fate/audio.mak        |  3 ++
> > tests/ref/fate/s337m-wav    | 11 ++++++
> > 12 files changed, 185 insertions(+), 28 deletions(-)  create mode 100644 libavformat/s337m.h  create mode 100644 tests/ref/fate/s337m-wav
> 
> I think I have not received any feedback for this v5 posted 3 weeks
> ago. I can rebase everything if it can help for reviewing (or applying
> if you think it is close to be accepted).

A patch that mixes so many different changes has little chances to be
accepted as is. You need to separate changes by function. It would also
increase the chances of review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201109/6bb10d11/attachment.sig>


More information about the ffmpeg-devel mailing list