[FFmpeg-devel] libdav1d: use film grain export flag to export AVFilmGrainParams side data

Lynne dev at lynne.ee
Thu Nov 12 15:22:11 EET 2020


Nov 12, 2020, 13:03 by andreas.rheinhardt at gmail.com:

> Lynne:
>
>>
>> @@ -420,7 +485,7 @@ static av_cold int libdav1d_close(AVCodecContext *c)
>>  static const AVOption libdav1d_options[] = {
>>  { "tilethreads", "Tile threads", OFFSET(tile_threads), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, DAV1D_MAX_TILE_THREADS, VD },
>>  { "framethreads", "Frame threads", OFFSET(frame_threads), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, DAV1D_MAX_FRAME_THREADS, VD },
>> -    { "filmgrain", "Apply Film Grain", OFFSET(apply_grain), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, VD },
>> +    { "filmgrain", "Apply Film Grain (deprecated)", OFFSET(apply_grain), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, VD },
>>
>
> A better way to mark an option as deprecated is to set
> AV_OPT_FLAG_DEPRECATED.
>

Thanks, locally changed to:
{ "filmgrain", "Apply Film Grain", OFFSET(apply_grain), AV_OPT_TYPE_BOOL, { .i64 = -1 }, -1, 1, VD | AV_OPT_FLAG_DEPRECATED },


More information about the ffmpeg-devel mailing list