[FFmpeg-devel] [PATCH 3/3] avcodec/nvdec_av1: fix setting film grain parameters for frames with update_grain == 0

[James Almer]

On 11/12/2020 6:19 PM, Timo Rothenpieler wrote:
> Are you sure this is necessary at all?
> If apply_grain is 0, the value of those should be entirely irrelevant.

This is not about apply_grain == 0, but about apply_grain == 1 && 
update_grain == 0.
In those cases, the parser only reads a frame index from the bitstream 
(film_grain_params_ref_idx), and you're supposed to get the FG values 
from said referenced frame.

As is, nvdec_av1 is filling all CUVIDAV1PICPARAMS FG fields except 
apply_grain and random_seed with zeroes on such frames.