[FFmpeg-devel] [PATCH 2/7] avcodec/vp3dsp: Use unsigned constant to avoid undefined integer overflow in ff_vp3dsp_set_bounding_values()

[Michael Niedermayer]

On Fri, Nov 13, 2020 at 05:44:44PM +1100, Peter Ross wrote:
> On Tue, Nov 10, 2020 at 12:04:51AM +0100, Michael Niedermayer wrote:
> > Fixes: signed integer overflow: 64 * 33686018 cannot be represented in type 'int'
> > Fixes: 26911/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-4904975073017856
> > 
> > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  libavcodec/vp3dsp.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c
> > index f485fba1f6..ec859a679d 100644
> > --- a/libavcodec/vp3dsp.c
> > +++ b/libavcodec/vp3dsp.c
> > @@ -490,5 +490,5 @@ void ff_vp3dsp_set_bounding_values(int * bounding_values_array, int filter_limit
> >      }
> >      if (value)
> >          bounding_values[128] = value;
> > -    bounding_values[129] = bounding_values[130] = filter_limit * 0x02020202;
> > +    bounding_values[129] = bounding_values[130] = filter_limit * 0x02020202U;
> >  }
> > -- 
> > 2.17.1
> 
> please apply

will apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I do not agree with what you have to say, but I'll defend to the death your
right to say it. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201113/e1d3a8a6/attachment.sig>