[FFmpeg-devel] [PATCH 5/7] avformat/wavdec: Avoid zeroing written to array
Anton Khirnov
anton at khirnov.net
Sat Nov 14 12:12:15 EET 2020
Quoting Michael Niedermayer (2020-11-10 00:04:54)
> Fixes: OOM
> Fixes: 26934/clusterfuzz-testcase-minimized-ffmpeg_dem_W64_fuzzer-5996784213819392
>
> Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
> libavformat/wavdec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
> index a81f2c7a67..6e5f4ccc12 100644
> --- a/libavformat/wavdec.c
> +++ b/libavformat/wavdec.c
> @@ -920,7 +920,7 @@ static int w64_read_header(AVFormatContext *s)
> if (chunk_size == UINT32_MAX || (filesize >= 0 && chunk_size > filesize))
> return AVERROR_INVALIDDATA;
>
> - value = av_mallocz(chunk_size + 1);
> + value = av_malloc(chunk_size + 1);
This looks highly suspicious as a fix for anything other than
performance.
--
Anton Khirnov
More information about the ffmpeg-devel
mailing list