[FFmpeg-devel] [PATCH 2/2] avcodec/av1dec: derive skip_mode_frame_idx only where it's used

[James Almer]

On 11/14/2020 2:32 PM, Timo Rothenpieler wrote:
> On 14.11.2020 16:08, James Almer wrote:
>> On 11/14/2020 12:01 PM, Timo Rothenpieler wrote:
>>> I still strongly dislike this whole thing.
>>> The same logic is ran essentially twice.
>>>
>>> But I also really don't like putting all this stuff into the hwaccel.
>>> That's way more logic than a hwaccel integration should have to do.
>>
>> Atm, only nvdec cares about these fields, and since all reference 
>> AV1RawFrameHeader are now available in hwaccel->start_frame(), it 
>> seemed proper to have it there.
>>
>> Eventually, a software implementation will be added to av1dec, and 
>> this code will have to be moved back. But if you are really against 
>> this set, then I'll withdraw it.
> 
> An ideal solution would would only run this logic once, in the AV1 
> decoder/parser.
> Which right now is in a bit of temporary not-really-a-decoder limbo, so 
> of course it's not perfect.
> 
> So if this will likely be needed for the software decoder in the future, 
> leaving it there in the first place seems better?
> Or would it get in the way for decoder development?

Best case scenario, it's used. Worst case scenario, it's replaced. So 
yes, in the long run it may be better to leave it here.
My intention with moving it to the only hwaccel uses it was to ensure 
it's not run for those that don't.

Since you want to keep nvdec_av1.c as clean as possible, I'm withdrawing 
this set.

> I don't want to hold up development on that front.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".