[FFmpeg-devel] [PATCH] avcodec: deprecate thread_safe_callbacks

Anton Khirnov anton at khirnov.net
Fri Nov 27 16:49:01 EET 2020


Quoting Anton Khirnov (2020-10-29 15:01:22)
> They add considerable complexity to frame-threading implementation,
> which includes an unavoidably leaking error path, while the advantages
> of this option to the users are highly dubious.
> 
> It should be always possible and desirable for the callers to make their
> get_buffer2() implementation thread-safe, so deprecate this option.
> ---
> Postponed the removal until major 60, also documented this explicitly in
> APIchanges, so users can test for it.
> ---
>  doc/APIchanges             |  5 +++
>  doc/multithreading.txt     |  3 +-
>  fftools/ffmpeg.c           |  2 ++
>  libavcodec/avcodec.h       | 13 ++++++--
>  libavcodec/pthread_frame.c | 68 +++++++++++++++++++++++++++++++++++---
>  libavcodec/thread.h        |  4 +++
>  libavcodec/utils.c         | 13 ++++++++
>  libavcodec/version.h       |  5 ++-
>  8 files changed, 102 insertions(+), 11 deletions(-)

pushed

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list