[FFmpeg-devel] [PATCH 4/4] avcodec/magicyuvenc: Use more correct cast in compare function

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Thu Oct 8 22:18:42 EEST 2020


There is no need to cast const away (even if it was harmless) and to
copy the object at all.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
 libavcodec/magicyuvenc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c
index 1b8bb53114..440b3514c3 100644
--- a/libavcodec/magicyuvenc.c
+++ b/libavcodec/magicyuvenc.c
@@ -280,9 +280,9 @@ typedef struct PackageMergerList {
 
 static int compare_by_prob(const void *a, const void *b)
 {
-    PTable a_val = *(PTable *)a;
-    PTable b_val = *(PTable *)b;
-    return a_val.prob - b_val.prob;
+    const PTable *a2 = a;
+    const PTable *b2 = b;
+    return a2->prob - b2->prob;
 }
 
 static void magy_huffman_compute_bits(PTable *prob_table, HuffEntry *distincts,
-- 
2.25.1



More information about the ffmpeg-devel mailing list