[FFmpeg-devel] [PATCH] avformat/webvttdec, enc: correctly process files containing STYLE, REGION blocks

[Jan Ekström]

On Tue, Oct 13, 2020 at 12:07 AM Dave Evans <dave.evans at m2amedia.tv> wrote:
>
> This patch fixes the total failure to parse cues when style and region
> definition blocks are contained in the input file, and ensures those blocks
> are written to the output when copying.
>

Thank you for taking time to add a FATE test, but unfortunately I am
not sure if this test tests the functionality you have added.

You have added what appears to be parsing of webvtt styles into
extradata in the demuxer, and then writing it out in the muxer. And
the test just outputs this webvtt into ASS, which doesn't keep any of
this since the decoder doesn't translate the newly inserted things
into ASS styles :)

So, I think a more fitting test would be to add this to the webvtt
tests with -c copy and pushing it out as webvtt, I would think?

Jan