[FFmpeg-devel] [PATCH] libavfilter/af_mcompand: Check for failure to allocate memory

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Tue Oct 13 05:58:17 EEST 2020


Chris Miceli:
> This commit fixes some unchecked memory allocations from #8931.
> ---
>  libavfilter/af_mcompand.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/libavfilter/af_mcompand.c b/libavfilter/af_mcompand.c
> index f142573bea..5309d884a5 100644
> --- a/libavfilter/af_mcompand.c
> +++ b/libavfilter/af_mcompand.c
> @@ -386,8 +386,17 @@ static int config_output(AVFilterLink *outlink)
>          }
>  
>          s->bands[i].attack_rate = av_calloc(outlink->channels, sizeof(double));
> +        if (!s->bands[i].attack_rate) {
> +            return AVERROR(ENOMEM);
> +        }
>          s->bands[i].decay_rate = av_calloc(outlink->channels, sizeof(double));
> +        if (!s->bands[i].decay_rate) {
> +            return AVERROR(ENOMEM);
> +        }
>          s->bands[i].volume = av_calloc(outlink->channels, sizeof(double));
> +        if (!s->bands[i].volume) {
> +            return AVERROR(ENOMEM);
> +        }
>          for (k = 0; k < FFMIN(nb_attacks / 2, outlink->channels); k++) {
>              char *tstr3 = av_strtok(p3, ",", &saveptr3);
>  
> 
The {} are unnecessary.

- Andreas


More information about the ffmpeg-devel mailing list