[FFmpeg-devel] [PATCH v3 1/8] avcodec/movtextenc: Fix potential use of uninitialized value
Andreas Rheinhardt
andreas.rheinhardt at gmail.com
Sat Oct 17 10:37:38 EEST 2020
Background colour was never initialized if no style was available.
Use a sane default of zero (i.e. completely transparent).
Fixes Coverity issue #1461471.
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
---
No change for this patch since last time; I am just resending all because
I have added a few patches that I intend to backport and that therefore
should be applied before "Simplify writing to AVBPrint".
libavcodec/movtextenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/movtextenc.c b/libavcodec/movtextenc.c
index 5f60b8db61..11db240ab7 100644
--- a/libavcodec/movtextenc.c
+++ b/libavcodec/movtextenc.c
@@ -205,7 +205,7 @@ static int encode_sample_description(AVCodecContext *avctx)
ASS *ass;
ASSStyle *style;
int i, j;
- uint32_t tsmb_size, tsmb_type, back_color, style_color;
+ uint32_t tsmb_size, tsmb_type, back_color = 0, style_color;
uint16_t style_start, style_end, fontID, count;
int font_names_total_len = 0;
MovTextContext *s = avctx->priv_data;
--
2.25.1
More information about the ffmpeg-devel
mailing list