[FFmpeg-devel] [PATCH 0/5] Fix adpcm_swf support in WAV.

[Anton Khirnov]

Quoting Zane van Iperen (2020-10-18 04:13:57)
> 
> 
> On 16/10/20 4:22 pm, Zane van Iperen wrote:
> > 
> > adpcm_swf support in WAV is completely broken. block_align isn't set correctly, so
> > the demuxer gives incorrect packets to the decoder. The encoder doesn't provide a
> > value for block_align, so it's set to 1.
> > 
> > All of this has no bearing on (de)muxing to FLV.
> > 
> > See https://trac.ffmpeg.org/ticket/5829.
> > 
> 
> Ping. I'd really like another set of eyes on this, especially because 
> I'm tweaking
> the behaviour of the WAV muxer.

I am no expert on the intricacies of wav, but it looks simple enough.
I'm just wondering if ff_put_wav_header() is not a better place for the
check.

-- 
Anton Khirnov