[FFmpeg-devel] [PATCH 3/4] avcodec/vp3: Unify initializing and freeing VLC tables

Andreas Rheinhardt andreas.rheinhardt at gmail.com
Wed Oct 21 07:59:28 EEST 2020


Peter Ross:
> On Tue, Oct 20, 2020 at 09:53:54AM +0200, Andreas Rheinhardt wrote:
>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
>> ---
>>  libavcodec/vp3.c     | 163 ++++++++++++-------------------------------
>>  libavcodec/vp3data.h |  22 ++----
>>  libavcodec/vp4data.h |  22 ++----
>>  3 files changed, 55 insertions(+), 152 deletions(-)
>>
>> diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c
>> index 7ee65c8062..e629a18b8e 100644
>> --- a/libavcodec/vp3.c
>> +++ b/libavcodec/vp3.c
>> @@ -257,11 +257,9 @@ typedef struct Vp3DecodeContext {
>>      int *nkf_coded_fragment_list;
>>      int num_kf_coded_fragment[3];
>>  
>> -    VLC dc_vlc[16];
>> -    VLC ac_vlc_1[16];
>> -    VLC ac_vlc_2[16];
>> -    VLC ac_vlc_3[16];
>> -    VLC ac_vlc_4[16];
>> +    /* The first 16 of the following VLCs are for the dc coefficients;
>> +       the others are four groups of 16 VLCs each for ac coefficients. */
>> +    VLC xc_vlc[80];
> 
> personal choice: coeff_vlc[5 * 16] would make this clearer for me
> 

Changed and applied.

- Andreas


More information about the ffmpeg-devel mailing list