[FFmpeg-devel] [PATCH 6/6] lavc: un-avpriv avpriv_bprint_to_extradata()

[Anton Khirnov]

Quoting James Almer (2020-10-27 01:10:47)
> On 10/26/2020 10:41 AM, Anton Khirnov wrote:
> > It has not been used outside of lavc since 6f69f7a8bf6.
> > 
> > Also, move it to the only place where it is used.
> 
> Shouldn't you keep the symbol around until the bump? Even though it was
> not used by other libraries, it was nonetheless still exported by lavc.
> A simple version define preprocessor check like Andreas mentioned is
> enough, no need to add a new FF_API define for avpriv functions.

Just being exported doesn't mean we have to maintain compatibility for
it, IMO. The only code that could have legally used it is in other libs,
but there is no such code since before last bump.

-- 
Anton Khirnov