[FFmpeg-devel] [PATCH 1/1] avformat: mca: relax a condition check to be able to play certain files

liushuyu at aosc.io liushuyu at aosc.io
Thu Oct 29 07:44:20 EET 2020


On 2020-10-02 02:14, Paul B Mahol wrote:
> On Thu, Oct 01, 2020 at 11:53:36PM -0600, liushuyu at aosc.io wrote:
>> From: liushuyu <liushuyu at aosc.io>
>> 
>> In certain mca files, the coefficient table is in the data section
>> instead of the header section. In this case, the coefficient offset
>> relative to the header ending marker is a negative value thus failing
>> the original condition check at line 146.
>> 
>> The new check just check if the coefficient offset is within the file
>> range (since there is no way to know where the actual audio samples 
>> are
>> without the correct header information).
>> ---
>>  libavformat/mca.c | 10 +++++-----
>>  1 file changed, 5 insertions(+), 5 deletions(-)
>> 
> 
> LGTM, remind me to apply this if I forgot.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".

Hi there,

I am very sorry but are there any more issues that prevent this patch 
from being applied?

Thanks,
Zixing


More information about the ffmpeg-devel mailing list