[FFmpeg-devel] [PATCH v4] avcodec: add av1 VAAPI decoder

[Wang, Fei W]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Mark
> Thompson
> Sent: Thursday, October 29, 2020 5:18 AM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v4] avcodec: add av1 VAAPI decoder
> 
> On 02/10/2020 15:28, Fei Wang wrote:
> > Example cmdline:
> > ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -v verbose \
> > -c:v av1 -i input.ivf -pix_fmt yuv420p -vsync passthrough -f md5     \
> > -y out.md5
> >
> > Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> > ---
> >   Changelog                 |   1 +
> >   configure                 |   3 +
> >   libavcodec/Makefile       |   1 +
> >   libavcodec/av1dec.c       |  18 ++-
> >   libavcodec/hwaccels.h     |   1 +
> >   libavcodec/vaapi_av1.c    | 274
> ++++++++++++++++++++++++++++++++++++++
> >   libavcodec/vaapi_decode.c |   6 +
> >   libavcodec/version.h      |   2 +-
> >   8 files changed, 304 insertions(+), 2 deletions(-)
> >   create mode 100644 libavcodec/vaapi_av1.c
> 
> I think this is ok, but I can't test it myself.  Can you rebase against the recent
> changes in av1dec and retest that it is still good?

Rebased with patch v5, and test looks good to me. Thanks.

> 
> A kindof-related question: how does the selection of reference frames for skip
> modes work?  VAAPI isn't being given the SkipModeFrame array, and it doesn't
> appear to have the order hints to be able to work out which frames it should be
> using itself.

Actually in media-driver, it maintains a reference frames parameter list which is used
to record and update reference frame's info. And refHint can be got in this list, and
with current frame's OrderHint (set by order_hint in VADecPictureParameterBufferAV1),
then can work out SkipModeFrame array following spec.

The detail implementation in media-driver is:
https://github.com/intel/media-driver/blob/d934d6c48644227ab066d013a105335ad25ce2bc/media_driver/media_driver_next/agnostic/common/codec/hal/dec/av1/packet/decode_av1_picture_packet.cpp#L1470 

> 
> Thanks,
> 
> - Mark
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
> with subject "unsubscribe".