[FFmpeg-devel] [PATCH v3 3/3] fate/filter-video: add 10bit test for unsharp filter

[Nicolas George]

lance.lmwang at gmail.com (12020-10-30):
> Sorry, I ignore it for I haven't realized it's a question in fact.

Please do not ignore things people write to you. If they (I) took time
writing it, there must be a reason.

> Without the first scale, it'll report error, but without the final scale,
> no error report but it's not work as expected, do you think it's necessary
> to report error in the case?

As I said, the final scale is necessary for big-endian architectures.
Did you test on a big-endian architecture? If not, then you do not see
any consequence for this filter, but it needs to be there.

The first scale can be avoided if you use testsrc2, as I said. If you
use vsynth, it is necessary. Testing that requires less extra code is
better.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20201030/4fe464dd/attachment.sig>