[FFmpeg-devel] [PATCH 4/4] avformat/mov: Stash mfra size if we're reading it anyway

Derek Buitenhuis derek.buitenhuis at gmail.com
Tue Sep 1 18:49:40 EEST 2020


On 01/09/2020 16:36, James Almer wrote:
> mfra_size in this function was an int32_t, so storing the output of
> avio_rb32() could end up with a negative value.
> It'll no longer be the case now that you made mfra_size in MOVContext an
> uint32_t.

How was that ever valid in the first place, considering avio_rb32 returns an
unsigned 32-bit integer?

- Derek


More information about the ffmpeg-devel mailing list