[FFmpeg-devel] [PATCH 15/25] avfilter/af_headphone: Avoid intermediate buffers II

Paul B Mahol onemda at gmail.com
Wed Sep 9 04:22:25 EEST 2020


On Tue, Sep 08, 2020 at 11:18:46PM +0200, Andreas Rheinhardt wrote:
> When the headphone filter is configured to perform its processing in the
> frequency domain, it allocates (among other things) two pairs of
> buffers, all of the same size. One pair is used to store data in it
> during the initialization of the filter; the other pair is only
> allocated lateron. It is zero-initialized and yet its data is
> immediately overwritten by the content of the other pair of buffers
> mentioned above; the latter pair is then freed.
> 
> This commit eliminates the pair of intermediate buffers.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
> ---
>  libavfilter/af_headphone.c | 33 +++++++--------------------------
>  1 file changed, 7 insertions(+), 26 deletions(-)
> 

should be fine if does not break usage.


More information about the ffmpeg-devel mailing list