[FFmpeg-devel] [PATCH] avfilter/avf_concat: check for possible integer overflow

[Marton Balint]

On Sun, 13 Sep 2020, Paul B Mahol wrote:

> There is nothing much currently that can be done to recover from
> this situation so just return AVERROR_BUG error code.
>
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
> libavfilter/avf_concat.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavfilter/avf_concat.c b/libavfilter/avf_concat.c
> index 5608ed9ac6..295a340515 100644
> --- a/libavfilter/avf_concat.c
> +++ b/libavfilter/avf_concat.c
> @@ -251,6 +251,8 @@ static int send_silence(AVFilterContext *ctx, unsigned in_no, unsigned out_no,
>
>     if (!rate_tb.den)
>         return AVERROR_BUG;
> +    if (seg_delta < -cat->in[in_no].pts)
> +        return AVERROR_BUG;

Isn't this supposed to be simply (seg_delta < cat->in[in_no].pts) ?

Thanks,
Marton


>     nb_samples = av_rescale_q(seg_delta - cat->in[in_no].pts,
>                               outlink->time_base, rate_tb);
>     frame_nb_samples = FFMAX(9600, rate_tb.den / 5); /* arbitrary */
> -- 
> 2.17.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".