[FFmpeg-devel] [PATCH 03/10] avformat/argo_brp: remove an allocation

[Zane van Iperen]

On Sun, 20 Sep 2020 10:13:48 +0200
"Andreas Rheinhardt" <andreas.rheinhardt at gmail.com> wrote:

> > @@ -444,6 +429,5 @@ AVInputFormat ff_argo_brp_demuxer = {
> >      .priv_data_size = sizeof(ArgoBRPDemuxContext),
> >      .read_probe     = argo_brp_probe,
> >      .read_header    = argo_brp_read_header,
> > -    .read_packet    = argo_brp_read_packet,
> > -    .read_close     = argo_brp_read_close
> > +    .read_packet    = argo_brp_read_packet
> 
> Unless you absolutely know that no entry will ever be added afterwards
> (e.g. if you have a sentinel), you should add a trailing comma as this
> means that if you add/remove a line later, you will leave the other
> lines as they are. If not, the diff will be unnecessarily bigger and
> more complicated and the usefulness of git blame will suffer (if you
> applied the above, git blame would show that this commit added the
> read_pack line and one would have to go further into the history to see
> the commit that really did it).
> So just remove the offending read_close, but leave the other stuff
> untouched.

Whoops, never meant to remove it. Have fixed locally.