[FFmpeg-devel] [PATCH 2/2] avformat/rtsp: allocate correct max number of pollfds

["zhilizhao(赵志立)"]

> On Sep 27, 2020, at 6:26 AM, Andriy Gelman <andriy.gelman at gmail.com> wrote:
> 
> From: Andriy Gelman <andriy.gelman at gmail.com>
> 
> There is one general rtsp connection plus two connections per stream (rtp/rtcp).
> 
> Signed-off-by: Andriy Gelman <andriy.gelman at gmail.com>
> ---
> libavformat/rtsp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
> index 5d8491b74b..90f912feb9 100644
> --- a/libavformat/rtsp.c
> +++ b/libavformat/rtsp.c
> @@ -1994,7 +1994,7 @@ static int udp_read_packet(AVFormatContext *s, RTSPStream **prtsp_st,
>     int *fds = NULL, fdsnum, fdsidx;
> 
>     if (!p) {
> -        p = rt->p = av_malloc_array(2 * (rt->nb_rtsp_streams + 1), sizeof(struct pollfd));
> +        p = rt->p = av_malloc_array(2 * rt->nb_rtsp_streams + 1, sizeof(struct pollfd));

LGTM. I’m not sure is it appropriate to modify sizeof(struct pollfd) to sizeof(*p) in this patch.

>         if (!p)
>             return AVERROR(ENOMEM);
> 
> -- 
> 2.27.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".