[FFmpeg-devel] [PATCH] avcodec/av1dec: check avctx->hwaccel when hwaccel pix_fmt selected

[James Almer]

On 9/28/2020 11:33 PM, Xiang, Haihao wrote:
> On Sat, 2020-09-26 at 13:05 -0300, James Almer wrote:
>> On 9/25/2020 4:35 AM, Xiang, Haihao wrote:
>>> Since commit e46f34e8 was merged, I also saw the same error message when I
>>> tested my QSV av1 patch (
>>> http://ffmpeg.org/pipermail/ffmpeg-devel/2020-September/270234.html) however
>>> the
>>> command worked well for me.
>>>
>>> [av1 @ 0x55b1604c42d0] Your platform doesn't suppport hardware accelerated
>>> AV1
>>> decoding.
>>> [av1 @ 0x55b1604c42d0] Failed to get pixel format.
>>> [av1 @ 0x55b1604c42d0] video_get_buffer: image parameters invalid
>>> [av1 @ 0x55b1604c42d0] get_buffer() failed
>>> [av1 @ 0x55b1604c42d0] thread_get_buffer() failed
>>> [av1 @ 0x55b1604c42d0] Failed to allocate space for current frame.
>>> [av1 @ 0x55b1604c42d0] Get current frame error
>>>
>>> I agree with Fei that the user will be confused with this error message.
>>>
>>> Thanks
>>> Haihao
>>
>> I guess we could change it to warning, but every other printed message
>> will be an error and there's not much else we can do.
>>
>> I sent a patchset that prevents calling get_buffer() when no pix_fmt is
>> set, so the errors it will print from then on will be less scary.
> 
> What's the subject of your patchset? I'd like to give a try with your patchset.
> 
> Thanks
> Haihao

First patch in the set is called "[PATCH 1/8] avcodec/cbs: add a flush
callback to CodedBitstreamType".