[FFmpeg-devel] [PATCH 2/2] avcodec/av1_metadata_bsf: Check for the existence of units

[James Almer]

On 4/2/2021 12:39 PM, Andreas Rheinhardt wrote:
> Fixes a crash with ISOBMFF extradata containing no OBUs.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
>   libavcodec/av1_metadata_bsf.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/av1_metadata_bsf.c b/libavcodec/av1_metadata_bsf.c
> index 8cafe461d1..328db5c0da 100644
> --- a/libavcodec/av1_metadata_bsf.c
> +++ b/libavcodec/av1_metadata_bsf.c
> @@ -120,7 +120,7 @@ static int av1_metadata_update_fragment(AVBSFContext *bsf, AVPacket *pkt,
>       }
>   
>       // If a Temporal Delimiter is present, it must be the first OBU.
> -    if (frag->units[0].type == AV1_OBU_TEMPORAL_DELIMITER) {
> +    if (frag->nb_units && frag->units[0].type == AV1_OBU_TEMPORAL_DELIMITER) {
>           if (ctx->td == BSF_ELEMENT_REMOVE)
>               ff_cbs_delete_unit(frag, 0);
>       } else if (pkt && ctx->td == BSF_ELEMENT_INSERT) {

Should be ok. And backport it, too.