[FFmpeg-devel] [PATCH] avformat/mov: check offset for overflow in mov_probe()
Michael Niedermayer
michael at niedermayer.cc
Mon Apr 5 00:44:45 EEST 2021
Fixes: Invalid read of size 4
Fixes: ASAN_Deadlysignal.zip
Found-by: Hardik Shah <hardik05 at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
libavformat/mov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 7805330bf9..ef73f3199d 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -7161,6 +7161,8 @@ static int mov_probe(const AVProbeData *p)
score = FFMAX(score, AVPROBE_SCORE_EXTENSION);
break;
}
+ if ((uint64_t)size + 8 > INT64_MAX - offset)
+ break;
offset += size;
}
if (score > AVPROBE_SCORE_MAX - 50 && moov_offset != -1) {
--
2.17.1
More information about the ffmpeg-devel
mailing list