[FFmpeg-devel] [PATCH 2/3] avcodec/adpcm_swf: remove memory allocation during trellis encoding

Zane van Iperen zane at zanevaniperen.com
Thu Apr 8 10:15:51 EEST 2021



On 3/4/21 11:19 am, Zane van Iperen wrote:
> 
> 
> On 1/4/21 9:34 pm, Zane van Iperen wrote:
>> The block size is hardcoded, so the buffer size is always known.
>> Statically allocate the buffer on the stack.
>>
>> Signed-off-by: Zane van Iperen <zane at zanevaniperen.com>
>> ---
>>   libavcodec/adpcmenc.c | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
> 
> Ping on parts 2 and 3.
> 
> My concern with part 3 is the re-initialisation of fields from extradata. I'm not sure
> if it should be done on only init, or on both init and flush.
> _______________________________________________

Ping again. Will apply in a few days if no objections.


More information about the ffmpeg-devel mailing list