[FFmpeg-devel] [PATCH] avcodec/nellymoserenc: Fix segfault when using unsupported channels/rate

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Thu Apr 15 16:52:31 EEST 2021


NellyMoserEncodeContext.avctx is only set in init after these checks,
yet it is used by encode_end().
This is a regression since 0a56bfa71f751a2b25da8d060a019c1c75ca9d7b.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
Sorry for this. Will apply soon and backport.

 libavcodec/nellymoserenc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/libavcodec/nellymoserenc.c b/libavcodec/nellymoserenc.c
index 99ede2f42b..8670431dcc 100644
--- a/libavcodec/nellymoserenc.c
+++ b/libavcodec/nellymoserenc.c
@@ -138,10 +138,8 @@ static av_cold int encode_end(AVCodecContext *avctx)
 
     ff_mdct_end(&s->mdct_ctx);
 
-    if (s->avctx->trellis) {
-        av_freep(&s->opt);
-        av_freep(&s->path);
-    }
+    av_freep(&s->opt);
+    av_freep(&s->path);
     ff_af_queue_close(&s->afq);
     av_freep(&s->fdsp);
 
-- 
2.27.0



More information about the ffmpeg-devel mailing list