[FFmpeg-devel] [PATCH 1/2] avcodec/adpcmenc Adds encoder for Westwood ADPCM.
Zane van Iperen
zane at zanevaniperen.com
Fri Apr 23 16:48:15 EEST 2021
On 23/4/21 6:51 pm, Aidan Richmond wrote:
> ---
> libavcodec/Makefile | 1 +
> libavcodec/adpcmenc.c | 32 ++++++++++++++++++++++++++++++--
> libavcodec/allcodecs.c | 1 +
> 3 files changed, 32 insertions(+), 2 deletions(-)
>
All looks mostly fine. Just a minor nit:
Could you add a ":" to the commit header? It should be:
"avcodec/adpcmenc: Adds encoder for Westwood ADPCM."
Same for the next patch too.
Any chance of getting a FATE test? A simple ENCDEC in tests/fate/acodec.mak should suffice.
Zane
More information about the ffmpeg-devel
mailing list