[FFmpeg-devel] [PATCH v4 3/3] avcodec/adpcm: Fixes output from Westwood ADPCM.

[Zane van Iperen]

On 25/4/21 11:41 am, Zane van Iperen wrote:

> Interesting, FATE didn't catch it for me. Which test is it?
> 
> $ make fate-adpcm fate-acodec fate-westwood-aud SAMPLES=fate-suite/
> 
> All pass for me.
> 

Never mind, found it.

>> Both the sample from the ticket as well as the fate-sample
>> (vqa/cc-demo1-partial.vqa) are 22050 Hz, mono, s16; the fate sample is
>> version 2, the new sample version 0. None of them test the version 3
>> codepath, so the change to it is untested.
> 
> Yeah, don't know where stereo came from. I need to sleep more...
> 
> What I meant was see this. Top is before, bottom is after:
> 
> https://0x0.st/-mex.png
> 

I've also confirmed all the "https://samples.ffmpeg.org/game-formats/vqa/Tiberian Sun VQAs" samples
exhibit the same behaviour without the patch.

>> I have tested a few files and the changes to the non-version 3 codepath
>> seem to be correct; I have also found out that your commit
>> c012f9b265e172de9c240c9dfab8665936fa3e83 made decoding
>> https://samples.ffmpeg.org/game-formats/vqa/Tiberian Sun
>> VQAs/startup.vqa (which is a version 3 format ima-ws file) crash.
>>
> 
> I've fixed the crash, see https://ffmpeg.org/pipermail/ffmpeg-devel/2021-April/279504.html
> 
> 

Once the patch (and my crash fix) are merged, I'll submit a test case for v3 VQA files so this doesn't happen again.