[FFmpeg-devel] [PATCH 28/34] avcodec/libmp3lame: Avoid copying packet data
Andreas Rheinhardt
andreas.rheinhardt at outlook.com
Mon Apr 26 01:34:42 EEST 2021
The libmp3lame encoder already uses an internal buffer, so that the
packet size is already known before allocating the packet; therefore
one can avoid another (implicit) intermediate buffer by setting
the min_size parameter in ff_alloc_packet2().
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
libavcodec/libmp3lame.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c
index 2beb28e569..bdb69424ee 100644
--- a/libavcodec/libmp3lame.c
+++ b/libavcodec/libmp3lame.c
@@ -264,7 +264,7 @@ static int mp3lame_encode_frame(AVCodecContext *avctx, AVPacket *avpkt,
ff_dlog(avctx, "in:%d packet-len:%d index:%d\n", avctx->frame_size, len,
s->buffer_index);
if (len <= s->buffer_index) {
- if ((ret = ff_alloc_packet2(avctx, avpkt, len, 0)) < 0)
+ if ((ret = ff_alloc_packet2(avctx, avpkt, len, len)) < 0)
return ret;
memcpy(avpkt->data, s->buffer, len);
s->buffer_index -= len;
@@ -296,7 +296,6 @@ static int mp3lame_encode_frame(AVCodecContext *avctx, AVPacket *avpkt,
AV_WL32(side_data + 4, discard_padding);
}
- avpkt->size = len;
*got_packet_ptr = 1;
}
return 0;
--
2.27.0
More information about the ffmpeg-devel
mailing list