[FFmpeg-devel] [PATCH v3 2/2] avformat/movenc: add support for TTML muxing

[Martin Storsjö]

On Mon, 26 Jul 2021, Jan Ekström wrote:

> From: Jan Ekström <jan.ekstrom at 24i.com>
>
> Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp')
> methods. This initial version also foregoes fragmentation support
> in case the built-in sample squashing is to be utilized, as this
> eases the initial review.
>
> Additionally, add basic tests for both muxing modes in MP4.
>
> Signed-off-by: Jan Ekström <jan.ekstrom at 24i.com>
> ---
> libavformat/Makefile             |   2 +-
> libavformat/isom.h               |   3 +
> libavformat/movenc.c             | 179 ++++++++++++++++++++++++++++++-
> libavformat/movenc.h             |   5 +
> libavformat/movenc_ttml.c        | 178 ++++++++++++++++++++++++++++++
> libavformat/movenc_ttml.h        |  31 ++++++
> tests/fate/subtitles.mak         |   4 +
> tests/ref/fate/sub-ttml-mp4-dfxp |  44 ++++++++
> tests/ref/fate/sub-ttml-mp4-stpp |  44 ++++++++
> 9 files changed, 487 insertions(+), 3 deletions(-)
> create mode 100644 libavformat/movenc_ttml.c
> create mode 100644 libavformat/movenc_ttml.h
> create mode 100644 tests/ref/fate/sub-ttml-mp4-dfxp
> create mode 100644 tests/ref/fate/sub-ttml-mp4-stpp

Thanks for addressing my comments. No further comments from me on this, 
but Andreas had more valuable comments on it than me, so I'd let him 
follow up and finish the review of this.

// Martin