[FFmpeg-devel] [PATCH v3 1/2] lavfi/vf_scale: use default swscale flags for simple and complex filter graph

Nicolas George george at nsup.org
Wed Aug 4 21:22:21 EEST 2021


Linjie Fu (12021-08-05):
> > > -    if (scale->flags_str) {
> > > +    if (*scale->flags_str) {
> > It could still be NULL, IIRC.
> sws_flags doesn't have a candidate for "" (NULL) [1].
> Hence NULL input for flags leads to a parsing issue:

It is not what I am talking about.

The application can set scale->flags to NULL. If it does,
*scale->flags_str crashes.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210804/93b787b8/attachment.sig>


More information about the ffmpeg-devel mailing list