[FFmpeg-devel] [PATCH v2] fftools/cmdutils: don't print build configuration by default

[James Almer]

On 8/6/2021 6:38 PM, Soft Works wrote:
> 
> 
>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
>> James Almer
>> Sent: Friday, 6 August 2021 23:17
>> To: ffmpeg-devel at ffmpeg.org
>> Subject: [FFmpeg-devel] [PATCH v2] fftools/cmdutils: don't print build
>> configuration by default
>>
>> Suggested-by: ffmpeg at fb.com
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>   fftools/cmdutils.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index
>> 912e881174..e6ae749167 100644
>> --- a/fftools/cmdutils.c
>> +++ b/fftools/cmdutils.c
>> @@ -1152,6 +1152,8 @@ static void print_all_libs_info(int flags, int level)
>> static void print_program_info(int flags, int level)  {
>>       const char *indent = flags & INDENT? "  " : "";
>> +    // Show config only if level is verbose or higher
>> +    int config_level = level <= AV_LOG_INFO ? AV_LOG_VERBOSE : level;
> 
> I don't think it will work this way because level is hardcoded to AV_LOG_INFO
> in both upstream calls.

I can hardcode it to VERBOSE if that's preferred. I made it this way 
since there could be new callers in the future that could choose a 
different level. Otherwise we could just remove the level parameter 
altogether.

> 
>>
>>       av_log(NULL, level, "%s version " FFMPEG_VERSION, program_name);
>>       if (flags & SHOW_COPYRIGHT)
>> @@ -1160,7 +1162,7 @@ static void print_program_info(int flags, int level)
>>       av_log(NULL, level, "\n");
>>       av_log(NULL, level, "%sbuilt with %s\n", indent, CC_IDENT);
>>
>> -    av_log(NULL, level, "%sconfiguration: " FFMPEG_CONFIGURATION "\n",
>> indent);
>> +    av_log(NULL, config_level, "%sconfiguration: "
>> FFMPEG_CONFIGURATION
>> + "\n", indent);
>>   }
>>
>>   static void print_buildconf(int flags, int level)
>> --
>> 2.32.0
>>
>> _______________________________________________
>> ffmpeg-devel mailing list
>> ffmpeg-devel at ffmpeg.org
>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>>
>> To unsubscribe, visit link above, or email ffmpeg-devel-request at ffmpeg.org
>> with subject "unsubscribe".
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>