[FFmpeg-devel] [PATCH v2] fftools/cmdutils: don't print build configuration by default

[James Almer]

On 8/6/2021 8:18 PM, Lynne wrote:
> 6 Aug 2021, 23:32 by jamrial at gmail.com:
> 
>> On 8/6/2021 6:29 PM, Lynne wrote:
>>
>>> 6 Aug 2021, 23:17 by jamrial at gmail.com:
>>>
>>>> Suggested-by: ffmpeg at fb.com
>>>> Signed-off-by: James Almer <jamrial at gmail.com>
>>>> ---
>>>>   fftools/cmdutils.c | 4 +++-
>>>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
>>>> index 912e881174..e6ae749167 100644
>>>> --- a/fftools/cmdutils.c
>>>> +++ b/fftools/cmdutils.c
>>>> @@ -1152,6 +1152,8 @@ static void print_all_libs_info(int flags, int level)
>>>>   static void print_program_info(int flags, int level)
>>>>   {
>>>>   const char *indent = flags & INDENT? "  " : "";
>>>> +    // Show config only if level is verbose or higher
>>>> +    int config_level = level <= AV_LOG_INFO ? AV_LOG_VERBOSE : level;
>>>>   av_log(NULL, level, "%s version " FFMPEG_VERSION, program_name);
>>>>   if (flags & SHOW_COPYRIGHT)
>>>> @@ -1160,7 +1162,7 @@ static void print_program_info(int flags, int level)
>>>>   av_log(NULL, level, "\n");
>>>>   av_log(NULL, level, "%sbuilt with %s\n", indent, CC_IDENT);
>>>>   -    av_log(NULL, level, "%sconfiguration: " FFMPEG_CONFIGURATION "\n", indent);
>>>> +    av_log(NULL, config_level, "%sconfiguration: " FFMPEG_CONFIGURATION "\n", indent);
>>>>   }
>>>>   static void print_buildconf(int flags, int level)
>>>> -- 
>>>> 2.32.0
>>>>
>>>
>>> That's even worse. Verbose is too verbose to be useful, especially
>>> when parsing H264 in MP4.
>>>
>>
>> I'm not sure i get it. I'm showing the build config only in verbose or higher to ensure bug reports don't require extra steps for the reporter. What exactly does H264 and MP4 have to do with this?
>>
> 
> It's spammy as hell. It prints every single NAL.
> Though I just checked, and it's spammy on debug, not verbose.
> Still, NAL printing should be absolutely trace level. It really makes
> debug a useless level, and everything else we have is quite responsibly
> printing what it should on debug.

My question is, what does unrelated output of verbose level have to do 
with this patch? If you prefer to use info because verbose is too 
verbose, then keep doing so?

> 
> 
>>> I'm happy with the default, and if we had to hide the build config,
>>> having it in -version and -loglevel verbose both would be better.
>>>
>>
>> This is exactly what this patch does.
>>
> 
> How? Does -version modify the log level?

No, it overrides the log callback with av_log_set_callback() with a 
function that ignores the level.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>