[FFmpeg-devel] [PATCH] fftools/cmdutils: don't print build configuration by default

[Stephen Hutchinson]

On 8/8/2021 12:31 AM, Gyan Doshi wrote:
> 
> 
> On 2021-08-06 11:34 pm, James Almer wrote:
>> From: Matthieu Patou <mpatou at fb.com>
>>
>> Suggested-by: ffmpeg at fb.com
>> Signed-off-by: James Almer <jamrial at gmail.com>
>> ---
>>   fftools/cmdutils.c | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
>> index 912e881174..fc58277df7 100644
>> --- a/fftools/cmdutils.c
>> +++ b/fftools/cmdutils.c
>> @@ -1160,7 +1160,8 @@ static void print_program_info(int flags, int 
>> level)
>>       av_log(NULL, level, "\n");
>>       av_log(NULL, level, "%sbuilt with %s\n", indent, CC_IDENT);
>> -    av_log(NULL, level, "%sconfiguration: " FFMPEG_CONFIGURATION 
>> "\n", indent);
>> +    if (flags & SHOW_CONFIG)
>> +        av_log(NULL, level, "%sconfiguration: " FFMPEG_CONFIGURATION 
>> "\n", indent);
> 
> I like it. If most users pasted the full log on their own initiative in 
> bug reports or Q&As then this would have been a negative but they don't.
> 
> I suggest to add an else clause that prints something like "Add 
> -buildconf to view configuration".
> 

Fun fact, the original -buildconf patchset included¹ that as an
option, by letting users opt to disable the configuration: line
entirely, whereby it would notify them to use -buildconf.

I have kept it rebased over the years in my github repo².

¹http://ffmpeg.org/pipermail/ffmpeg-devel/2013-November/151075.html

²https://github.com/qyot27/FFmpeg/commit/ce087ae0b72cf70fff29300b528122b7451cb4b7