[FFmpeg-devel] [PATCH 04/10] avfilter/formats: Factor common function combinations out

[Nicolas George]

Andreas Rheinhardt (12021-08-11):
> Several combinations of functions happen quite often in query_format
> functions; e.g. ff_set_common_formats(ctx, ff_make_format_list(sample_fmts))
> is very common. This commit therefore adds functions that are equivalent
> to commonly used function combinations in order to reduce code
> duplication.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

Excellent idea.

I would rather have ff_set_common as a prefix even in the all case:
ff_set_common_all...

Apart from that the changes in formats.* LGTM and I trust you for the
changes in individual filters, although I can take the time to look at
them more carefully if you want.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210811/7bdf31d4/attachment.sig>