[FFmpeg-devel] Subject: [PATCH] Cleanup code in truemotion1 decoder

[Michael Niedermayer]

On Sun, Aug 01, 2021 at 04:22:28PM +0000, ffmpegandmahanstreamer at e.email wrote:
> Per Andreas Rheinhardt request i'm splitting the working patches in two.

And this results in a commit message like this:
Author: ffmpegandmahanstreamer at e.email <ffmpegandmahanstreamer at e.email>
Date:   Sun Aug 1 16:22:28 2021 +0000

    Subject: [PATCH] Cleanup code in truemotion1 decoder
    
    Per Andreas Rheinhardt request i'm splitting the working patches in two.

Thats not good
"Subject: [PATCH]" doesnt belong in it
"Cleanup code in truemotion1 decoder" is too terse, what is cleaned upo why and how

Your Author name is also missing, is that intended ?
    
  
> ---
> This cleans up the code in the decode24bit and decode16bit functions by putting it in way that expresses the true intent while making it easier to read.
>  libavcodec/truemotion1.c | 36 ++++++++++++------------------------
>  1 file changed, 12 insertions(+), 24 deletions(-)
> 
> diff --git a/libavcodec/truemotion1.c b/libavcodec/truemotion1.c
> index 32d8fb4005..50c90e732d 100644
> --- a/libavcodec/truemotion1.c
> +++ b/libavcodec/truemotion1.c
> @@ -655,25 +655,19 @@ static void truemotion1_decode_16bit(TrueMotion1Context *s)
>          while (pixels_left > 0) {
>  
>              if (keyframe || ((mb_change_byte & mb_change_byte_mask) == 0)) {
> -
> +                
>                  switch (y & 3) {

unrelated
trailing whitespace

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Nations do behave wisely once they have exhausted all other alternatives. 
-- Abba Eban
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210814/36646d5f/attachment.sig>