[FFmpeg-devel] [PATCH v2 2/3] avcodec/h274: add film grain synthesis routine

Niklas Haas ffmpeg at haasn.xyz
Thu Aug 19 03:59:28 EEST 2021


On Wed, 18 Aug 2021 12:41:25 -0300 James Almer <jamrial at gmail.com> wrote:
> Will this not break compilation with msvc and such?

No. Unrecognized or unsupported pragmas are ignored by the
implementation (this is specified C behavior).

> Also, tree vectorization is know to cause issues in old GCC versions, 
> and even recent ones. I don't know if this is worth the potential 
> problems it could introduce, but i guess it can be done until someone 
> writes simd.

Can any of these issues be replicated for the code in question? It
sounds like a mostly theoretical risk/concern, whereas the slowdown is
quite real and measurable.


More information about the ffmpeg-devel mailing list