[FFmpeg-devel] [PATCH 02/10] avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilter
Nicolas George
george at nsup.org
Fri Aug 20 12:03:19 EEST 2021
Andreas Rheinhardt (12021-08-15):
> #define OFFSET(x) offsetof(CoreImageContext, x)
> @@ -663,8 +660,8 @@ const AVFilter ff_vf_coreimage = {
> .uninit = uninit,
> .priv_size = sizeof(CoreImageContext),
> .priv_class = &coreimage_class,
> - .inputs = vf_coreimage_inputs,
> - .outputs = vf_coreimage_outputs,
> + FF_FILTER_INPUTS(vf_coreimage_inputs),
> + FF_FILTER_OUTPUTS(vf_coreimage_outputs),
> .query_formats = query_formats,
> };
>
> @@ -685,6 +682,6 @@ const AVFilter ff_vsrc_coreimagesrc = {
> .priv_size = sizeof(CoreImageContext),
> .priv_class = &coreimagesrc_class,
> .inputs = NULL,
> - .outputs = vsrc_coreimagesrc_outputs,
> + FF_FILTER_OUTPUTS(vsrc_coreimagesrc_outputs),
In this file, you are using FF_FILTER_INPUTS and FF_FILTER_OUTPUTS
instead of just FILTER like everywhere else.
I suppose you missed it because it depends on a proprietary operating
system. I do not mind if you break it, but I suppose other would ;-)
LGTM apart from that.
Regards,
--
Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210820/de84db62/attachment.sig>
More information about the ffmpeg-devel
mailing list