[FFmpeg-devel] [PATCH] lavfi: merge AVFilterChannelLayouts into AVFilterFormats.

[Nicolas George]

Andreas Rheinhardt (12021-08-20):
> I do not really agree that such simple macros are hard to maintain. But
> I am also not concerned about the increased memory usage (or the fact
> that 32bit machines probably won't like it). And I like that it allows
> to remove several duplicate functions.
> If you think that it brings you closer to your other goals, then go
> ahead (but Michael or Anton or Paul might want to voice their opinions,
> too).

Thanks for the comment. I will leave some more time.

> That line should just be removed without replacement.

Ok.

> Have you checked whether there are any macros of this type for the
> current formats, where the type is switched from int to uint64_t with
> this patch? They should be ok given that the list in AVFilterFormats
> uses a length field and not a sentinel, so that all entries are >= 0,
> but it would not be nice to use a wrong type here.

Good catch. There were two. Between sample rates and formats, so the int
intermediate variable was enough, but better plan for the future.

> This function does no longer exist; the declaration should be removed, too.

Ok.

Patch updated, but I do not think it worth sending it again.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210820/8ce95260/attachment.sig>