[FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

[Ronald S. Bultje]

Hi,

On Tue, Aug 24, 2021 at 9:07 AM Olivier Crête <olivier.crete at collabora.com>
wrote:

> Hi Andreas,
>
> > Generally, one should forward error codes and not make up some on the
> > fly; in this case, the callee does not return proper error codes, so
> > this should be fixed, too (but not in the same commit and not
> > necessarily by you). Even more importantly, the callee emits an error
> > message, stating that an error will be ignored, which will no longer
> > true with this patch.
>
> If I understand correctly, the "ignoring" refers to the block being
> ignored because of errors, not to the error being ignored.
>

No, the opposite. He suggests to try:

ret = try_decode_wma();
if (ret < 0) return ret;

instead of:

if (ret < 0) return AVERROR_INVALIDDATA;

Ronald