[FFmpeg-devel] [PATCH] tests/fate: move TTML-in-MP4 tests from subtitles.mak to mov.mak

Martin Storsjö martin at martin.st
Wed Aug 25 22:58:27 EEST 2021


On Wed, 25 Aug 2021, Jan Ekström wrote:

> subtitles.mak utilizes a more strict comparator and - to be honest -
> the tests feel more at home in this location.
> ---

LGTM, although your commit message forgets to point out the relevant 
effect of it - we're not just doing this for sorting things in the most 
matching bucket, but because those tests were broken on Windows. Please 
mention that and mention that it was due to fate-sub-% getting 
CMP=rawdiff.

// Martin


More information about the ffmpeg-devel mailing list