[FFmpeg-devel] [PATCH] [RFC] Add option for writing detailed filtergraph information to file or stdout

Soft Works softworkz at hotmail.com
Thu Aug 26 14:41:26 EEST 2021



> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Nicolas George
> Sent: Thursday, 26 August 2021 13:12
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH] [RFC] Add option for writing
> detailed filtergraph information to file or stdout
> 
> Soft Works (12021-08-26):
> > - Instead you criticized my patch for its LOC count, even though
> that is
> >   just made up from the output writers code duplication...
> 
> You are mistaken here too. Unlike what you seem to think, I factored
> your saying that the writers would have to be de-duplicated in my
> accounting of the amount of code required.
> 
> The feature you propose is of dubious usefulness

??

> if not harmful, 

Seriously?


> would be only acceptable if it took very very little code.

I'm sure I could squeeze it into a few weird one-liners, LOL

> This is the end of the discussion from my side until you start to
> take
> maintenance and general usefulness into consideration in your
> discussion.

I do take "general usefulness" into account. That's actually my
primary motivation which originated from the fact that I find the 
patch that you have submitted not much useful in that form because
it targets only a very specific and limited niche that you're 
intending to use it for. While I agree that it is useful for your
specific task, that change is not of "general usefulness".
Instead of setting up and raising demands upon your patch, I 
have submitted an alternative that I'm considering more
useful for general use than yours; without going into details,
simply because it provides a lot more important information
that is lacking from your approach.

softworkz










More information about the ffmpeg-devel mailing list