[FFmpeg-devel] [PATCH v2 0/8] A New Take on the Immortal Sub2Video Code

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Nicolas George
> Sent: Monday, 30 August 2021 10:24
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 0/8] A New Take on the Immortal
> Sub2Video Code
> 
> Soft Works (12021-08-30):
> > v2 Update:
> >
> > - Implemented Andreas' suggestions
> > - overlay_subs filter:
> >   - removed duplicated code
> >   - implemented direct (no pre-conversion) blending of graphical
> >     subtitle rects
> >   - Supported input formats:
> >     - all packed RGB formats (with and without alpha)
> > 	- yuv420p, yuv422p, yuv444p
> >
> >
> > This patchset is about introducing filtering support for subtitles.
> 
> Rejected.
> 
> As I have explained to you, no subtitle support can be accepted until
> the negotiation process has been refactored to make adding a third
> media
> type less of a nightmare.
> 
> From your questions and remarks in other discussions, it seems
> obvious
> to me that you are missing something central about the format
> negotiation. That makes discussion with you at cross-purpose, a waste
> of
> your efforts and ours both, and that makes your patches unacceptable.

You didn't reply to my questions, neither did you explain your plans.

There are three - or actually just two relevant - subtitle formats 
for internal handling:

- AVSubtitleType.SUBTITLE_BITMAP
- AVSubtitleType.SUBTITLE_ASS

with regards to subtitles, there's no need for negotiation: It's 
either one or the other and as these are fundamentally different,
there's also no auto-conversion that needs to be handled.
Either a filter (or encoder) supports it or it doesn't.

Your proposals and plans might make sense for audio and video 
formats, but I don't see how this would affect subtitle filtering.

If you want to REJECT my submission, please be SPECIFIC instead
of responding with your usual set of personal insults.

softworkz