[FFmpeg-devel] [PATCH 4/5] avformat/movenc: reduce tfra box size when every sample is a sync sample

["zhilizhao(赵志立)"]

> On Dec 3, 2021, at 9:33 PM, Michael Niedermayer <michael at niedermayer.cc> wrote:
> 
> On Fri, Dec 03, 2021 at 01:06:56PM +0800, Zhao Zhili wrote:
>> ---
>> libavformat/movenc.c  |  8 +++++
>> libavformat/movenc.h  |  1 +
>> tests/ref/fate/movenc | 80 +++++++++++++++++++++----------------------
>> 3 files changed, 49 insertions(+), 40 deletions(-)
> 
> Heres a testcase this seems to break
> 
> ffmpeg -i matrixbench_mpeg2.mpg -movflags frag_keyframe -t 3 /tmp/1/file.ismv
> ismindex -n /tmp/1/file /tmp/1/file.ismv
> cd /tmp/1
> ismindex -split -n file-split file.ismv
> 
> Before the patch there is
> 
> 'Fragments(audio=0)'
> in
> './QualityLevels(127986)'
> 
> afterwards the directory is empty
> 

ismindex mistakes 0 number of entry as ENOMEM.

    track->chunks  = avio_rb32(f);
    track->offsets = av_calloc(track->chunks, sizeof(*track->offsets));
    if (!track->offsets) {
        track->chunks = 0;
        ret = AVERROR(ENOMEM);
        goto fail;
    }

Now I think the feature makes more trouble than useful. Please drop patch 4
and 5.

> 
> [...]
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
> 
> Old school: Use the lowest level language in which you can solve the problem
>            conveniently.
> New school: Use the highest level language in which the latest supercomputer
>            can solve the problem without the user falling asleep waiting.
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>